In order to prevent blocks to extend from cms blocks, flag all cms

blocks as final. closes #1109
luyadev · Dec 19, 2016 · 8f9b9e3 · 8f9b9e3
1 parent 6fb4f66
commit 8f9b9e3
Show file tree

Hide file tree

Showing 21 changed files with 21 additions and 20 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,7 @@ The changelog contains informations about bug fixes, new features or bc breaking
 
 - [#1102](https://github.com/luyadev/luya/issues/1102) Removed News Module Tag table and replace by admin modules Tag models.
 - [#1098](https://github.com/luyadev/luya/issues/1098) Changed luya\base\Widget view path behavior to default implementation with option to enable app view paths lookup.
+- [#1109](https://github.com/luyadev/luya/issues/1109) In order to prevent blocks to extend from cms blocks, flag all cms blocks as final.
 
 ### Added
 

diff --git a/modules/cms/src/frontend/blocks/AudioBlock.php b/modules/cms/src/frontend/blocks/AudioBlock.php
@@ -11,7 +11,7 @@
  *
  * @author Basil Suter <basil@nadar.io>
  */
-class AudioBlock extends TwigBlock
+final class AudioBlock extends TwigBlock
 {
     /**
      * @inheritDoc

diff --git a/modules/cms/src/frontend/blocks/DevBlock.php b/modules/cms/src/frontend/blocks/DevBlock.php
@@ -11,7 +11,7 @@
  *
  * @author Basil Suter <basil@nadar.io>
  */
-class DevBlock extends TwigBlock
+final class DevBlock extends TwigBlock
 {
     public $module = 'cms';
 

diff --git a/modules/cms/src/frontend/blocks/FileListBlock.php b/modules/cms/src/frontend/blocks/FileListBlock.php
@@ -11,7 +11,7 @@
  *
  * @author Basil Suter <basil@nadar.io>
  */
-class FileListBlock extends TwigBlock
+final class FileListBlock extends TwigBlock
 {
     public $module = 'cms';
 

diff --git a/modules/cms/src/frontend/blocks/FormBlock.php b/modules/cms/src/frontend/blocks/FormBlock.php
@@ -13,7 +13,7 @@
  * @author Basil Suter <basil@nadar.io>
  *
  */
-class FormBlock extends TwigBlock
+final class FormBlock extends TwigBlock
 {
     public $module = 'cms';
 

diff --git a/modules/cms/src/frontend/blocks/HtmlBlock.php b/modules/cms/src/frontend/blocks/HtmlBlock.php
@@ -11,7 +11,7 @@
  *
  * @author Basil Suter <basil@nadar.io>
  */
-class HtmlBlock extends TwigBlock
+final class HtmlBlock extends TwigBlock
 {
     public $module = 'cms';
 

diff --git a/modules/cms/src/frontend/blocks/ImageBlock.php b/modules/cms/src/frontend/blocks/ImageBlock.php
@@ -14,7 +14,7 @@
  *
  * @author Basil Suter <basil@nadar.io>
  */
-class ImageBlock extends TwigBlock
+final class ImageBlock extends TwigBlock
 {
     public $module = 'cms';
 

diff --git a/modules/cms/src/frontend/blocks/ImageTextBlock.php b/modules/cms/src/frontend/blocks/ImageTextBlock.php
@@ -14,7 +14,7 @@
  *
  * @author Basil Suter <basil@nadar.io>
  */
-class ImageTextBlock extends TwigBlock
+final class ImageTextBlock extends TwigBlock
 {
     public $module = 'cms';
 

diff --git a/modules/cms/src/frontend/blocks/LayoutBlock.php b/modules/cms/src/frontend/blocks/LayoutBlock.php
@@ -11,7 +11,7 @@
  *
  * @author Basil Suter <basil@nadar.io>
  */
-class LayoutBlock extends TwigBlock
+final class LayoutBlock extends TwigBlock
 {
     public $module = 'cms';
 

diff --git a/modules/cms/src/frontend/blocks/LineBlock.php b/modules/cms/src/frontend/blocks/LineBlock.php
@@ -10,7 +10,7 @@
  *
  * @author Basil Suter <basil@nadar.io>
  */
-class LineBlock extends TwigBlock
+final class LineBlock extends TwigBlock
 {
     public $cacheEnabled = true;
 

diff --git a/modules/cms/src/frontend/blocks/LinkButtonBlock.php b/modules/cms/src/frontend/blocks/LinkButtonBlock.php
@@ -11,7 +11,7 @@
  *
  * @author Basil Suter <basil@nadar.io>
  */
-class LinkButtonBlock extends TwigBlock
+final class LinkButtonBlock extends TwigBlock
 {
     public $cacheEnabled = true;
 

diff --git a/modules/cms/src/frontend/blocks/ListBlock.php b/modules/cms/src/frontend/blocks/ListBlock.php
@@ -11,7 +11,7 @@
  *
  * @author Basil Suter <basil@nadar.io>
  */
-class ListBlock extends TwigBlock
+final class ListBlock extends TwigBlock
 {
     public $module = 'cms';
 

diff --git a/modules/cms/src/frontend/blocks/MapBlock.php b/modules/cms/src/frontend/blocks/MapBlock.php
@@ -10,7 +10,7 @@
  *
  * @author Basil Suter <basil@nadar.io>
  */
-class MapBlock extends TwigBlock
+final class MapBlock extends TwigBlock
 {
     public $module = 'cms';
 

diff --git a/modules/cms/src/frontend/blocks/ModuleBlock.php b/modules/cms/src/frontend/blocks/ModuleBlock.php
@@ -16,7 +16,7 @@
  *
  * @author Basil Suter <basil@nadar.io>
  */
-class ModuleBlock extends TwigBlock
+final class ModuleBlock extends TwigBlock
 {
     public $module = 'cms';
 

diff --git a/modules/cms/src/frontend/blocks/QuoteBlock.php b/modules/cms/src/frontend/blocks/QuoteBlock.php
@@ -11,7 +11,7 @@
  *
  * @author Basil Suter <basil@nadar.io>
  */
-class QuoteBlock extends TwigBlock
+final class QuoteBlock extends TwigBlock
 {
     public $module = 'cms';
 

diff --git a/modules/cms/src/frontend/blocks/SpacingBlock.php b/modules/cms/src/frontend/blocks/SpacingBlock.php
@@ -10,7 +10,7 @@
  *
  * @author Basil Suter <basil@nadar.io>
  */
-class SpacingBlock extends TwigBlock
+final class SpacingBlock extends TwigBlock
 {
     public $module = 'cms';
 

diff --git a/modules/cms/src/frontend/blocks/TableBlock.php b/modules/cms/src/frontend/blocks/TableBlock.php
@@ -11,7 +11,7 @@
  *
  * @author Basil Suter <basil@nadar.io>
  */
-class TableBlock extends TwigBlock
+final class TableBlock extends TwigBlock
 {
     public $module = 'cms';
 

diff --git a/modules/cms/src/frontend/blocks/TextBlock.php b/modules/cms/src/frontend/blocks/TextBlock.php
@@ -12,7 +12,7 @@
  *
  * @author Basil Suter <basil@nadar.io>
  */
-class TextBlock extends TwigBlock
+final class TextBlock extends TwigBlock
 {
     public $module = 'cms';
 

diff --git a/modules/cms/src/frontend/blocks/TitleBlock.php b/modules/cms/src/frontend/blocks/TitleBlock.php
@@ -11,7 +11,7 @@
  *
  * @author Basil Suter <basil@nadar.io>
  */
-class TitleBlock extends TwigBlock
+final class TitleBlock extends TwigBlock
 {
     public $module = 'cms';
 

diff --git a/modules/cms/src/frontend/blocks/VideoBlock.php b/modules/cms/src/frontend/blocks/VideoBlock.php
@@ -11,7 +11,7 @@
  *
  * @author Basil Suter <basil@nadar.io>
  */
-class VideoBlock extends TwigBlock
+final class VideoBlock extends TwigBlock
 {
     public $module = 'cms';
 

diff --git a/modules/cms/src/frontend/blocks/WysiwygBlock.php b/modules/cms/src/frontend/blocks/WysiwygBlock.php
@@ -11,7 +11,7 @@
  *
  * @author Basil Suter <basil@nadar.io>
  */
-class WysiwygBlock extends TwigBlock
+final class WysiwygBlock extends TwigBlock
 {
     /**
      * @inheritDoc