Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin: List dropdown position of right toggler chevron #1464

Closed
dev7ch opened this issue Sep 7, 2017 · 6 comments
Closed

Admin: List dropdown position of right toggler chevron #1464

dev7ch opened this issue Sep 7, 2017 · 6 comments
Assignees
Milestone

Comments

@dev7ch
Copy link
Contributor

dev7ch commented Sep 7, 2017

luya_list_dropdown

In my opinion its not correct, that the X replaces the chevron after the selection.

@nadar
Copy link
Contributor

nadar commented Sep 8, 2017

what would you suggest then? do we have already a similar use case?

@nadar nadar added this to the 1.0.0 milestone Sep 8, 2017
@dev7ch
Copy link
Contributor Author

dev7ch commented Sep 8, 2017

I suggest that the chevron should remain on its position, the close X left next to it, not right, quick fix.

A prime solution would be to bound the X at the selected term, e.g. 2spalten.
This would open us the opportunity to use this nice list dropdown for checkbox arrays ( multiple selection) in future.

@dev7ch
Copy link
Contributor Author

dev7ch commented Sep 8, 2017

and yes we have used this dropdown list often, which is haveing the same behaviour

@nadar
Copy link
Contributor

nadar commented Sep 8, 2017

i think switching X and chevron would be a good a solution. i am not even sure how comfortable it would be to have the X to the current selected list, assume u have a list with 50 entries.

dev7ch added a commit to dev7ch/luya that referenced this issue Sep 12, 2017
@dev7ch
Copy link
Contributor Author

dev7ch commented Sep 12, 2017

the icon positions are fixed in the pending PR, i assume the multiple selections is an other issue, this could be closed;

@nadar nadar closed this as completed in 7c9714e Sep 12, 2017
@nadar
Copy link
Contributor

nadar commented Sep 12, 2017

Thanks for fix but it still looks the same...

image

@nadar nadar reopened this Sep 12, 2017
dev7ch added a commit to dev7ch/luya that referenced this issue Sep 12, 2017
dev7ch added a commit to dev7ch/luya that referenced this issue Sep 12, 2017
@nadar nadar closed this as completed in 9c0e449 Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants