Exception handling for theme loading #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadar
suggested changes
Oct 26, 2019
nadar
suggested changes
Oct 27, 2019
nadar
approved these changes
Dec 9, 2019
|
Code Climate has analyzed commit b19dd1a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 64.8% (0.0% change). View more on Code Climate. |
nadar
added a commit
that referenced
this pull request
Dec 27, 2019
* Translation helper controler * PHPdoc * Correct parameter order for help * Documentation for block preview luyadev/luya-module-cms#83 * Revert PHP doc * Travis mysql connection failed * config with env scope * used call_user_func for callback * Update Config.php * theme load without exception as default * theme load without exception as default * theme load without exception as default * Update ThemeManager.php * changelog #1969 * Update CHANGELOG.md * add php doc * theme management image for guide #1983 * Update app-themes.md Co-authored-by: Basil <git@nadar.io>
nadar
added a commit
that referenced
this pull request
Apr 6, 2020
* Translation helper controler * PHPdoc * Correct parameter order for help * Documentation for block preview luyadev/luya-module-cms#83 * Revert PHP doc * Travis mysql connection failed * config with env scope * used call_user_func for callback * Update Config.php * theme load without exception as default * theme load without exception as default * theme load without exception as default * Update ThemeManager.php * changelog #1969 * Update CHANGELOG.md * add php doc * theme management image for guide #1983 * Update app-themes.md * close #1970 * Update CHANGELOG.md * Relative theme path to alias path * Changelog * Relative vendor path to alias path * Tests for Relative vendor path to alias path Co-authored-by: Basil <git@nadar.io>
nadar
added a commit
that referenced
this pull request
Apr 13, 2020
* Translation helper controler * PHPdoc * Correct parameter order for help * Documentation for block preview luyadev/luya-module-cms#83 * Revert PHP doc * Travis mysql connection failed * config with env scope * used call_user_func for callback * Update Config.php * theme load without exception as default * theme load without exception as default * theme load without exception as default * Update ThemeManager.php * changelog #1969 * Update CHANGELOG.md * add php doc * theme management image for guide #1983 * Update app-themes.md * Theme command * Create theme command * Changelog Co-authored-by: Basil <git@nadar.io>
nadar
added a commit
that referenced
this pull request
Jul 2, 2020
* Translation helper controler * PHPdoc * Correct parameter order for help * Documentation for block preview luyadev/luya-module-cms#83 * Revert PHP doc * Travis mysql connection failed * config with env scope * used call_user_func for callback * Update Config.php * theme load without exception as default * theme load without exception as default * theme load without exception as default * Update ThemeManager.php * changelog #1969 * Update CHANGELOG.md * add php doc * theme management image for guide #1983 * Update app-themes.md * Theme command * Create theme command * Changelog * fixed theme/create command #2020 * Changelog #2020 * Fix unit test for theme create command * Fix unit test for theme create command Co-authored-by: Basil <git@nadar.io>
boehsermoe
added a commit
to boehsermoe/luya
that referenced
this pull request
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As default thememanager should not throw exception if any theme file is missing or anything else.