fix: reject on non-zero exit codes (serialport#2046)

* fix: reject on non-zero exit codes
* fix: use more descriptive error message

packages/bindings/lib/linux-list.js

@@ -42,6 +42,7 @@ function listLinux() {
     const ports = []
     const ude = childProcess.spawn('udevadm', ['info', '-e'])
     const lines = ude.stdout.pipe(new Readline())
+    ude.on('close', code => code && reject(new Error(`Error listing ports udevadm exited with error code: ${code}`)))
     ude.on('error', reject)
     lines.on('error', reject)
 

packages/bindings/lib/linux-list.test.js

@@ -113,4 +113,18 @@ describe('listLinux', () => {
       assert.containSubset(ports, portOutput)
     })
   })
+
+  it('rejects on non-zero exit codes', () => {
+    const list = listLinux()
+    listLinux.emit('close', 1)
+
+    list.then(
+      () => {
+        assert.fail('should not resolve for non-zero exit codes')
+      },
+      error => {
+        assert(error, new Error('Error listing ports udevadm exited with error code: 1'))
+      }
+    )
+  })
 })

packages/bindings/lib/mocks/linux-list.js

@@ -4,13 +4,14 @@ const EventEmitter = require('events')
 const proxyquire = require('proxyquire')
 const Readable = require('stream').Readable
 let mockPorts
+let event
 
 proxyquire.noPreserveCache()
 const listLinux = proxyquire('../linux-list', {
   child_process: {
     spawn() {
-      const event = new EventEmitter()
       const stream = new Readable()
+      event = new EventEmitter()
       event.stdout = stream
       stream.push(mockPorts)
       stream.push(null)
@@ -24,6 +25,10 @@ listLinux.setPorts = ports => {
   mockPorts = ports
 }
 
+listLinux.emit = function() {
+  event.emit.apply(event, arguments)
+}
+
 listLinux.reset = () => {
   mockPorts = {}
 }