Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After Effects not detected as active #1982

Closed
probablykasper opened this issue Sep 29, 2022 · 11 comments
Closed

After Effects not detected as active #1982

probablykasper opened this issue Sep 29, 2022 · 11 comments
Labels
bug Something isn't working unactionable Further action is not possible due to lack of information or support

Comments

@probablykasper
Copy link

Describe the bug

After Effects seems to always show up in the same spot in AltTab. If AE is in focus, it's showing far down the list. If I tab out of AE, it's still far down the list.

It's probably related to #647, though in that one AE doesn't show up at all. I'm guessing that's because they have enabled Hide apps with no open window.

I don't think Contexts has this problem. Maybe it's solvable by detecting what app is currently focused and showing that at the top of the list.

Screenshots / video

image

@probablykasper probablykasper added the bug Something isn't working label Sep 29, 2022
@sgametrio
Copy link

I happened to see this behaviour with VSCode too!

@lwouis
Copy link
Owner

lwouis commented Oct 31, 2022

Apps with no window being at the end is normal. The issue is, I imagine, that you have open windows? So you would expect the windows to be listed higher.

If you show the thumbnails, it should make the situation clearer.

Now why the windows are not recognized is most likely due to #1324. I'm going to close this ticket for now as I don't think it's actionable. Feel free to post more information regarding the issue if you think it's not related to #1324 (e.g. activte the thumbnails, then record a video showing the various steps, as well as listing the steps with bullet points). Thank you

@lwouis lwouis closed this as completed Oct 31, 2022
@lwouis lwouis added the unactionable Further action is not possible due to lack of information or support label Oct 31, 2022
@probablykasper
Copy link
Author

Apps with no window being at the end is normal. The issue is, I imagine, that you have open windows?

Yes, when I have the After Effects window focused (see screenshot), it doesn't show up at the top. That by itself isn't really a big problem, but it prevents you from alt+tabbing out and back.

Now why the windows are not recognized is most likely due to #1324

I'm not on macOS 12 yet, so I don't think that's the issue here.

Fix suggestion

When a window-less app is in focus (For example QuickTime Player), put the app 1st in the list. When the user tabs out of the app, show the window-less app 2nd in the list. I believe this is how Contexts works.

If it's undesirable behavior for some users, there could be an option to go back to the old behavior, but keep the new behavior for specific apps. You'd want After Effects to always use the new behavior because After Effects always has a window open.

@lwouis
Copy link
Owner

lwouis commented Oct 31, 2022

Please share steps to reproduce and a video

@probablykasper
Copy link
Author

It's just what's shown in the screenshot really:

  1. Open After Effects
  2. Press alt+tab

@lwouis
Copy link
Owner

lwouis commented Oct 31, 2022

Unfortunately, I don't pay for AE, so I can't really try it out myself. I checked on their website, and it's pretty high commitment to just try it out.

@lwouis
Copy link
Owner

lwouis commented Oct 31, 2022

If you're before macOS 12, I really wonder why AltTab wouldn't list AE windows. That's very unexpected/uncommon.

Maybe you could open AltTab in Terminal.app, wait for the logs to settle, then open WE, and share the logs you get? I'm curious if the OS is not sending the normal events maybe? It's highly unlikely.

The other explanation would be that AE windows are not real OS windows. I made a build which doesn't filter-out non-windows. Could you run it and tell me if it shows the AE windows?

@probablykasper
Copy link
Author

These are the logs from opening AE:

"OS event" "apps launched" [(94255, Optional("com.adobe.AfterEffects"))]
"Adding app" 94255 "com.adobe.AfterEffects"
"OS event" "apps launched" [(94270, Optional("com.adobe.GPUSniffer.application"))]
"OS event" "apps quit" [(94270, Optional("com.adobe.GPUSniffer.application"))]
"Deinit app" "com.adobe.GPUSniffer.application"
"OS event" "apps launched" [(94272, Optional("com.adobe.TeamProjectsLocalHub.application"))]
"Accessibility event" "AXApplicationActivated" "iTerm2"

The other explanation would be that AE windows are not real OS windows. I made a build which doesn't filter-out non-windows. Could you run it and tell me if it shows the AE windows?

That did fix it! It shows the window, including the thumbnail

@lwouis
Copy link
Owner

lwouis commented Oct 31, 2022

That did fix it! It shows the window, including the thumbnail

Then it means AE windows are not real windows. It's a bug on their side. You should open a ticket for them so they fix it. If it affects AltTab, it must affect other accessibility apps.

I could add a workaround like I've done in the past for a few apps, but it may then list some UI elements as windows in AltTab. Some poorly written apps will use NSWindow (macOS standard windows) to implement tooltips or menus. These tooltips/menus will then show in AltTab as windows (since they are instances of NSWindow). This is the purpose of AltTab filtering out "real and fake" windows.

Could you test out this build? I applied the same whitelist as I did Adobe Audition. It's a bit more restrictive than a blanket-statement whitelist, so if it works it would be better.

To insist again: this is a bug on AE side. It should be reported. Screen readers and other apps are probably broken with AE.

@probablykasper
Copy link
Author

To insist again: this is a bug on AE side. It should be reported. Screen readers and other apps are probably broken with AE.

Got it, will report. Shocking to see a bug in After Effects, hopefully they fix it in just a few short years

Could you test out this build? I applied the same whitelist as I did Adobe Audition. It's a bit more restrictive than a blanket-statement whitelist, so if it works it would be better.

AE lets you drag different UI elements/panels out into their own separate windows. The old build showed the panels individually. The new one only shows the main window, which is great.

AE also has a preference window, and when it's open, you can't interact with the main window. The preferences window showed up separately in the old build, not only the main window shows up. I think it's good that it doesn't show them separately, but it also means that when you tab into AE, the non-interactive window is what gets focused.

Ideally it would match Mission Control: Only the main window shows up in Mission Control, but when you click it, the Preference window keeps focus (but it's also not a huge deal, I don't spend all my life preferences)

@lwouis
Copy link
Owner

lwouis commented Oct 31, 2022

Yes, all these details about AE non-conforming windows is why for an app like this I would typically run it on my machine and fine-tune the whitelisting of their "windows". I remember Steam being particularly aggregious and time-consuming to create a good experience with, for instance.

Since I can't run AE on my machine, and you wrote that the latest build I share is a decent experience, I think I'll release this change.

@lwouis lwouis reopened this Oct 31, 2022
@lwouis lwouis closed this as completed in 7b54873 Nov 2, 2022
lwouis pushed a commit that referenced this issue Nov 2, 2022
# [6.49.0](v6.48.0...v6.49.0) (2022-11-02)

### Bug Fixes

* command+backtick not working if stage manager is on (closes [#2053](#2053)) ([848ae5f](848ae5f))
* crash when setting some shortcut combinations (closes [#2061](#2061)) ([8b2d659](8b2d659))
* hide minimize and fullscreen thumbnail buttons for tabs ([b62c422](b62c422))
* improve key repeat-rate when held (closes [#2026](#2026)) ([1821dea](1821dea))
* key-above-tab on international keyboards (closes [#1190](#1190)) ([4c31740](4c31740))
* thumbnails would sometimes be the wrong size ([1065c0d](1065c0d))
* wrong focus after active app becomes windowless (closes [#2065](#2065)) ([281b3ed](281b3ed))

### Features

* improve some localizations ([292e6b0](292e6b0))
* play alert sound for unavailable thumbnail shortcuts ([fd84a9a](fd84a9a))
* support adobe after effects non-standard windows (closes [#1982](#1982)) ([7b54873](7b54873))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unactionable Further action is not possible due to lack of information or support
Projects
None yet
Development

No branches or pull requests

3 participants