Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesn't work on macos 10.15 "Catalina" #29

Closed
thomas-ignidus opened this issue Oct 15, 2019 · 5 comments
Closed

doesn't work on macos 10.15 "Catalina" #29

thomas-ignidus opened this issue Oct 15, 2019 · 5 comments

Comments

@thomas-ignidus
Copy link

No description provided.

@OranShuster
Copy link

OranShuster commented Oct 16, 2019

Running the code in xcode
in computeOpenWindows, cgWindows() returns an empty list of windows

CGWindowListCopyWindowInfo([.excludeDesktopElements, .optionOnScreenOnly], kCGNullWindowID) returns some items (28 when i tested)
but after the filter there are 0 items in the dictionary
(i used .count for the dictionary size)

I never seen swift before but i'm preetty sure i got this right

Here is a Gist of the logs

using kCGWindowOwnerName instead of kCGWindowName works for me
you could also print an "empty" windows when there are no windows so people will atleast know the shortcut is triggering the app but there is another problem

@lwouis
Copy link
Owner

lwouis commented Oct 17, 2019

To clarify the status of this: Catalina introduced a new permission for Screen Recording:

image
image

Side-note: the app already requires accessibility permission to be granted:

image

PR #33 seems promising to implement this new requirement from Catalina.

@lwouis
Copy link
Owner

lwouis commented Oct 17, 2019

To people up-voting this issue: you didn't get any prompt when using the app? You are supposed to see something like this:

image

@lwouis lwouis closed this as completed in cbfa586 Oct 17, 2019
lwouis pushed a commit that referenced this issue Oct 17, 2019
## [1.4.5](v1.4.4...v1.4.5) (2019-10-17)

### Bug Fixes

* handle new Screen Recording permission on Catalina (closes [#29](#29)) ([cbfa586](cbfa586))
@lwouis
Copy link
Owner

lwouis commented Oct 17, 2019

This issue should be fixed in release 1.4.5. Please try it and re-open this issue if it doesn't fix it for you :)

@eugenesvk
Copy link

To clarify the status of this: Catalina introduced a new permission for Screen Recording:

Just a quick note: for the app to open this window asking for permissions you might need to have a running Finder process, without which it'd be impossible to do anything (you can't add screen recording permissions manually)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants