Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Quit button is not accessible when the system language is RTL #3487

Closed
ShlomoCode opened this issue Jul 14, 2024 · 1 comment
Closed

The Quit button is not accessible when the system language is RTL #3487

ShlomoCode opened this issue Jul 14, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ShlomoCode
Copy link
Contributor

Describe the bug

When the system language of macOS is RTL language (Hebrew/Arabic), macOS places its traffic light buttons on the right side of the window instead of on the left, which causes a lack of access to the Quit button (see screenshot)
Note that what determines is the system language and not the specific language for the application, even if one is selected in System Settings (it doesn't make much sense on Apple's part, but that's how it works).

Screenshots / video

CleanShot 2024-07-14 at 02 47 23@2x
CleanShot 2024-07-14 at 02 39 15@2x

Steps to reproduce the bug

  1. Go to System Settings > Language & Region
  2. Change the language to hebrew
  3. Open alt-tab settings

Your environment

  • AltTab version: 6.71.0
  • macOS version: 14.5
@ShlomoCode ShlomoCode added the bug Something isn't working label Jul 14, 2024
@ShlomoCode ShlomoCode mentioned this issue Jul 14, 2024
Closed
@lwouis
Copy link
Owner

lwouis commented Jul 14, 2024

Hi,

Thank you for raising this issue, and thank you for sharing an MR to fix it!

I've left a comment on the MR. Could you please give it a look?
After that, I think we should be able to merge and ship it in the next release 👍

Thank you 🙇

@lwouis lwouis closed this as completed in d3dfd54 Jul 14, 2024
lwouis pushed a commit that referenced this issue Jul 14, 2024
@semantic-release-bot
chore(release): 6.72.0 [skip ci]
97951e7 
# [6.72.0](v6.71.0...v6.72.0) (2024-07-14)

### Bug Fixes

* preferences window quit button supports right-to-left languages ([d3dfd54](d3dfd54)), closes [#3487](#3487)

### Features

* don't show caps-lock indicator as a window (closes [#3171](#3171)) ([2e15732](2e15732))
* improve da/he localizations ([3d98b64](3d98b64))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: adjust Quit button position based on system language direction ShlomoCode/alt-tab-macos
2 participants
@lwouis @ShlomoCode