Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In the kubernetes end to end tests (which use Ginkgo), the structure is that there is a general framework and then specific test cases. Both have BeforeEach and AfterEach statements and the execution order is
Quite often, the Test's BeforeEach sets up some infrastructure required for the test and the AfterEach tears it down.
However, if a test fails, we want to collect diags as close to the failure as possible. We could find and modify all the innermost AfterEach's and add diags to them all. But it would be much nicer to be able to have a JustAfterEach in the Framework that all the tests use that works in a similar way to JustBeforeEach.
This problem was mentioned in kubernetes/kubernetes#34318, although that wasn't explicitly about this.