Wrong handling of paths without params

[asulykos]

Rewrite rules having no parameters, automatically applied to every path (even to the non-matching ones.)

The problem is in getTargetUrl function of util.js.

The toUrl is automatically set to the to parameter, and will be returned even if the path doesn't match. For non-matching paths the intact url parameter should be returned instead.

function getTargetUrl (from, to, url) {
  const { pathToRegexp } = require('path-to-regexp')
  const fromParams = []
  const re = pathToRegexp(from, fromParams)
  const fromMatches = re.exec(url)
  let toUrl = to // <--------- it should be 'url' if 'fromMatches' is undefined

  for (const [index, fromParam] of fromParams.entries()) {
    if (fromMatches && fromMatches[index + 1]) {
      fromParam.value = fromMatches[index + 1]
    }
  }

  /* replace named params */
  for (const fromParam of fromParams) {
    if (typeof fromParam.name === 'string') {
      if (fromParam.value) {
        toUrl = toUrl.replace(new RegExp(`:${fromParam.name}`, 'g'), fromParam.value)
      } else {
        toUrl = url
      }
    }
  }

  /* replace positional params */
  for (const fromParam of fromParams) {
    if (typeof fromParam.name !== 'string') {
      toUrl = url.replace(re, toUrl)
    }
  }

  return toUrl
}

[75lb]

Hi, could you post an example of a rewrite rule I can use to reproduce this bug please?

[asulykos]

Let's consider the following rules:

rewrite: [
  {
    from: '/login/(.*)',
    to: 'dist/login/$1'
  },
  {
    from: '/login',
    to: 'dist/login/index.html'
  }
]

Here with the first rule, I'd like to rewrite every path starting with /login/ to my dist folder path. This rule alone works, but as soon as I add the second one, everything will be redirected to 'dist/login/index.html'. The second rule doesn't have params to be replaced. getTargetUrl() will return the unmodified 'toUrl' which has been set to 'to' at the beginning of the function. (This 'to' variable holds 'dist/login/index.html'.)

[75lb]

Fixed and released in lws-rewrite v3.1.1 - please upgrade.

Thanks, let me know if you find any more issues!

[asulykos]

Thank you very much, that was really quick. :)