Rework monitors processing for desktop manager. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should not enumerate them but remember plugs instead and associate config with them. When monitor is getting plugged off then plugged on, it will get remembered config back.
|
It seems to be broken now: when I add a monitor, it doesn't come up there, while when I remove a monitor, it gets stuck in a loop in |
wb9688
reviewed
Mar 16, 2021
| @@ -2,7 +2,7 @@ | |||
| * app-config.c | |||
| * | |||
| * Copyright 2010 PCMan <pcman.tw@gmail.com> | |||
| * Copyright 2012-2014 Andriy Grytsenko (LStranger) <andrej@rep.kiev.ua> | |||
| * Copyright 2012-2021 Andriy Grytsenko (LStranger) <andrej@rep.kiev.ua> | |||
There was a problem hiding this comment.
Nitpick: I think you want 2012-2014, 2021 instead, because 2012-2021 would mean you've also touched the code in 2015, 2016, 2017, 2018, 2019, and 2020.
There was a problem hiding this comment.
I prefer to use simple range, anyways I did it everywhere before so it's too late for such details now. :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should not enumerate them but remember plugs instead and associate config with them.
When monitor is getting plugged off then plugged on, it will get remembered config back.
This change is made instead of #3 to handle it more correctly. Some fixes from #3 should be pulled separately though.