Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General styling for tables - Add _table.scss to /assets/scss/partials/vendor #445

Merged
merged 6 commits into from
Jul 24, 2024

Conversation

JohnMThompson
Copy link
Contributor

Description

Add simple CSS style for tables.

Issue Number:


Additional Information (Optional)

Added two changes, a _table.scss to the vendor folder and a corresponding entry in the main.scss file. This is an extremely simple table css style to help render in markdown tables

Before addition tables rendered like this:
image

After adding css, tables render like this:
Light mode
image

Dark mode
image


Checklist

Yes, I included all necessary artefacts, including:

  • Tests
  • Documentation
  • Implementation (Code and Ressources)
  • Example

Testing Checklist

Yes, I ensured that all of the following scenarios were tested:

  • Desktop Light Mode (Default)
  • Desktop Dark Mode
  • Desktop Light RTL Mode
  • Desktop Dark RTL Mode
  • Mobile Light Mode
  • Mobile Dark Mode
  • Mobile Light RTL Mode
  • Mobile Dark RTL Mode

Notify the following users

@netlify
Copy link

netlify bot commented Apr 14, 2023

Deploy Preview for anatole-demo ready!

Name Link
🔨 Latest commit bb0057e
🔍 Latest deploy log https://app.netlify.com/sites/anatole-demo/deploys/66a132e8584b7800088f4a42
😎 Deploy Preview https://deploy-preview-445--anatole-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 90
Accessibility: 88
Best Practices: 100
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarcloud
Copy link

sonarcloud bot commented Apr 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

sonarcloud bot commented Jul 24, 2024

@lxndrblz lxndrblz merged commit 4eee0da into lxndrblz:master Jul 24, 2024
5 checks passed
@lxndrblz lxndrblz added the enhancement New feature or request label Jul 24, 2024
@lxndrblz lxndrblz self-assigned this Jul 24, 2024
@lxndrblz lxndrblz linked an issue Jul 24, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to use table in markdown
2 participants