Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement multilingual portfolio data #481

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

sebastianlacuesta
Copy link
Contributor

Description

This pull request implements multilingual support for portfolio data.
Data for portfolio is looked at data/<language-code>/portfolio.yml first and if it doesn't exists, then we use data/portfolio.yml like before.

Issue Number:

#397

Checklist

Yes, I included all necessary artefacts, including:

  • Tests
  • Documentation
  • Implementation (Code and Ressources)
  • Example

I can add a spanish translation of the exampleSite and provide a working example if you want.


Testing Checklist

Yes, I ensured that all of the following scenarios were tested:

  • Desktop Light Mode (Default)
  • Desktop Dark Mode
  • Desktop Light RTL Mode
  • Desktop Dark RTL Mode
  • Mobile Light Mode
  • Mobile Dark Mode
  • Mobile Light RTL Mode
  • Mobile Dark RTL Mode

There's no porfolio example for RTL mode and I don't know how to test it.


Notify the following users

  • List users with @ to send Notifications

Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for anatole-demo failed.

Name Link
🔨 Latest commit f2f5138
🔍 Latest deploy log https://app.netlify.com/sites/anatole-demo/deploys/65694f586145e6000801b47e

Copy link

sonarcloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sebastianlacuesta
Copy link
Contributor Author

sebastianlacuesta commented Dec 1, 2023

I can´t reproduce the first error on my setup. No errors for me.

$ cd exampleSite && hugo --gc --minify --themesDir ../..
WARN  deprecated: config: languages.ar.description: custom params on the language top level was deprecated in Hugo v0.112.0 and will be removed in a future release. Put the value below [languages.ar.params]. See https://gohugo.io/content-management/multilingual/#changes-in-hugo-01120
Start building sites … 
hugo v0.120.3+extended linux/amd64 BuildDate=2023-11-07T23:07:34Z VendorInfo=debian:0.120.3-1

WARN  The "twitter_simple" shortcode will soon require two named parameters: user and id. See "/home/sebastian/go/src/github.com/sebastianlacuesta/anatole/exampleSite/content/english/post/rich-content.md:26:1"
WARN  _internal/google_analytics_async.html is no longer supported by Google and will be removed in a future version of Hugo

                   | EN | AR  
-------------------+----+-----
  Pages            | 65 | 19  
  Paginator pages  |  1 |  0  
  Non-page files   |  0 |  0  
  Static files     | 11 | 11  
  Processed images |  0 |  0  
  Aliases          | 13 |  9  
  Sitemaps         |  2 |  1  
  Cleaned          |  4 |  4  

Total in 189 ms

Copy link
Owner

@lxndrblz lxndrblz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebastianlacuesta LGTM. Thanks for your PR!

@lxndrblz lxndrblz merged commit d500419 into lxndrblz:master Jul 24, 2024
1 of 5 checks passed
@lxndrblz lxndrblz linked an issue Jul 24, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multilanguage for portfolio?
2 participants