Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decrease minimal height #263

Closed
excalibur1234 opened this issue Sep 27, 2016 · 4 comments
Closed

decrease minimal height #263

excalibur1234 opened this issue Sep 27, 2016 · 4 comments

Comments

@excalibur1234
Copy link

qterminal has a minimal height and width.
can its minimal height be decrease to e.g. the height of 2 lines?

i have many small scripts (e.g. to download youtube videos) and i like to run them in qterminal to see how much the script has progressed. but i do not need to see 12 lines of code (i see 12 lines of code in qterminal at minimum height with my current font size). 2 lines of code would be perfect.

i have used konsole for a short amount of time and it has a much lower minimal height. now, i miss such a feature in qterminal.

@jcc242
Copy link
Contributor

jcc242 commented Oct 1, 2016

Just familiarizing myself with the code, decided to take a look at this. Removed the minimumSize property from TabWidget in qterminal.ui. See attached screenshot, top terminal is konsole for comparison, bottom terminal is qterminal. To the right is the absolute minimum size I could shrink them both to.

I could commit this and file a pull request if desired. Do we want to specify a minimum width/height? I think it would be more difficult to specify minumum number of lines as it changes based on the font size, would need a signal/slot on font size change. Original minimum size is 320x200 (pixels?).

qterm-height

@excalibur1234
Copy link
Author

wow, this looks great!

i think a minimum height/width is useful. specifying them in pixels is ok.
i was mentioning "two line minimum height" more as a reference than something you would need to write code for.

200 pixels as the current minimum height sounds about right. this is about 1/5 of a 1920x1080 screen. as mentioned above, this is ok for doing terminal work, but not when you want a pop-up of qterminal in a screen edge with a progress bar of your running script.

i recommend to do a pull request and refer add a short text like "this PR solves #263". then, the lxqt team can discuss the advantages and disadvantages of your change.

@Vladimir-csp
Copy link

Dupe of #181.
I find terminals without menus or scrollbars (or anything except the terminal itself) very handy, as they can be resized down to 1 short line to show some terse useful output.
No minimal size should be set, just increment window size hints.

@pmattern pmattern mentioned this issue Oct 8, 2016
@agaida
Copy link
Member

agaida commented Nov 20, 2016

Closed with #265

@agaida agaida closed this as completed Nov 20, 2016
agaida added a commit that referenced this issue Aug 18, 2019
#181 - Minimum size
#263 - Decrease minimal height
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants