Draft: feat(req): add parameter to hand over complete CSR #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsballmann
commented
Nov 25, 2024
Comment on lines
55
to
+62
| ) | ||
| group.add_argument( | ||
| "-csrfile", | ||
| action="store", | ||
| metavar="CSR file name", | ||
| help="Path to CSR file for use with OpenSSL-generated Certificate Requests", | ||
| # Conflicts with -upn,-dns,-sid,-subject,-retrieve,-on-behalf-of,-pfx | ||
| ) |
There was a problem hiding this comment.
Suggested change
| ) | |
| group.add_argument( | |
| "-csrfile", | |
| action="store", | |
| metavar="CSR file name", | |
| help="Path to CSR file for use with OpenSSL-generated Certificate Requests", | |
| # Conflicts with -upn,-dns,-sid,-subject,-retrieve,-on-behalf-of,-pfx | |
| ) | |
| ) | |
| # Probably conflicts with -upn,-dns,-sid,-subject,-retrieve,-on-behalf-of,-pfx | |
| group.add_argument( | |
| "-csrfile", | |
| action="store", | |
| metavar="CSR file name", | |
| help="Path to CSR file for use with OpenSSL-generated Certificate Requests", | |
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds a parameter to the
reqsub-command to allow handing over a complete CSR instead of specifying only parts of it.This originates from rutgerputter#1 but I haven't reviewed myself, yet.