fix(plugin): clone the default items for slide,radio group, checkbox …

…group 修复轮播图、多选组、单选组的默认值
ly525 · Nov 23, 2019 · 141036f · 141036f
1 parent ea72021
commit 141036f
Show file tree

Hide file tree

Showing 3 changed files with 75 additions and 34 deletions.
diff --git a/front-end/h5/src/components/plugins/lbp-form-checkbox-group.js b/front-end/h5/src/components/plugins/lbp-form-checkbox-group.js
@@ -1,16 +1,24 @@
 import LbpFormRadio from './lbp-form-radio.js'
 
-const defaultItems = [
-  {
-    value: '选项A'
-  },
-  {
-    value: '选项B'
-  },
-  {
-    value: '选项C'
-  }
-]
+function getDefaultItems () {
+  // defaultItems.slice(0)[0] === defaultItems.slice(0)[0] -> true
+  // Object.assign(defaultItems)[0] === Object.assign(defaultItems)[0] -> true
+  // clone = (val) => JSON.parse(JSON.stringify(val))
+  // clone(defaultItems)[0] === clone(defaultItems)[0] -> false
+  const defaultItems = [
+    {
+      value: '选项A'
+    },
+    {
+      value: '选项B'
+    },
+    {
+      value: '选项C'
+    }
+  ]
+
+  return defaultItems
+}
 
 export default {
   name: 'lbp-form-checkbox-group',
@@ -29,7 +37,7 @@ export default {
     },
     items: {
       type: Array,
-      default: () => defaultItems,
+      default: () => getDefaultItems(),
       editor: {
         type: 'lbs-prop-text-enum-editor',
         label: '选项列表',

diff --git a/front-end/h5/src/components/plugins/lbp-form-radio-group.js b/front-end/h5/src/components/plugins/lbp-form-radio-group.js
@@ -1,17 +1,35 @@
+/*
+ * @Author: ly525
+ * @Date: 2019-11-23 12:35:43
+ * @LastEditors: ly525
+ * @LastEditTime: 2019-11-23 19:50:57
+ * @FilePath: /luban-h5/front-end/h5/src/components/plugins/lbp-form-radio-group.js
+ * @Github: https://github.com/ly525/luban-h5
+ * @Description: 表单单选组组件 #!en: radio group component
+ * @Copyright 2018 - 2019 luban-h5. All Rights Reserved
+ */
+
 import LbpFormRadio from './lbp-form-radio.js'
-// import { genUUID } from '../../utils/element.js'
 
-const defaultItems = [
-  {
-    value: '选项A'
-  },
-  {
-    value: '选项B'
-  },
-  {
-    value: '选项C'
-  }
-]
+function getDefaultItems () {
+  // defaultItems.slice(0)[0] === defaultItems.slice(0)[0] -> true
+  // Object.assign(defaultItems)[0] === Object.assign(defaultItems)[0] -> true
+  // clone = (val) => JSON.parse(JSON.stringify(val))
+  // clone(defaultItems)[0] === clone(defaultItems)[0] -> false
+  const defaultItems = [
+    {
+      value: '选项A'
+    },
+    {
+      value: '选项B'
+    },
+    {
+      value: '选项C'
+    }
+  ]
+
+  return defaultItems
+}
 
 export default {
   name: 'lbp-form-radio-group',
@@ -27,7 +45,7 @@ export default {
     },
     items: {
       type: Array,
-      default: () => defaultItems,
+      default: () => getDefaultItems(),
       editor: {
         type: 'lbs-prop-text-enum-editor',
         label: '选项列表',

diff --git a/front-end/h5/src/components/plugins/lbp-slide.js b/front-end/h5/src/components/plugins/lbp-slide.js
@@ -1,15 +1,30 @@
+/*
+ * @Author: ly525
+ * @Date: 2019-11-23 12:35:21
+ * @LastEditors: ly525
+ * @LastEditTime: 2019-11-23 19:53:14
+ * @FilePath: /luban-h5/front-end/h5/src/components/plugins/lbp-slide.js
+ * @Github: https://github.com/ly525/luban-h5
+ * @Description: #!zh: 轮播图组件 #!en slide component
+ * @Copyright 2018 - 2019 luban-h5. All Rights Reserved
+ */
+
 import { Swipe, SwipeItem } from 'vant'
 import 'vant/lib/swipe/style'
 import 'vant/lib/swipe-item/style'
 
-const defaultItems = [
-  {
-    image: 'https://img.yzcdn.cn/vant/apple-1.jpg'
-  },
-  {
-    image: 'https://img.yzcdn.cn/vant/apple-2.jpg'
-  }
-]
+function getDefaultItems () {
+  const defaultItems = [
+    {
+      image: 'https://img.yzcdn.cn/vant/apple-1.jpg'
+    },
+    {
+      image: 'https://img.yzcdn.cn/vant/apple-2.jpg'
+    }
+  ]
+
+  return defaultItems
+}
 
 export default {
   name: 'lbp-slide',
@@ -36,7 +51,7 @@ export default {
     },
     items: {
       type: Array,
-      default: () => defaultItems.slice(0),
+      default: () => getDefaultItems(),
       editor: {
         custom: true
       }