strengthen higher ranked where-bound to avoid breakage #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the current where-bound is sometimes weaker than the actual impl. We previously discarded them eagerly. This will break once rust-lang/rust#119820 lands
lcnr
changed the title
|
I do not fully understand the underlying issue, only that bounds need to be stricter tests are passing locally, so I think everything should be fine, thanks a lot for this out-of-the-blue PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current where-bound is weaker than the actual impl. Calling some functions, e.g.
fn to_boxes_have_common_continuumactually requires using different higher ranked lifetimes for&Boxand&Scalar. Trying to use the where-bounds in this case results in a higher-ranked region error. This previously compiled as we eagerly discarded the where-bounds and used the impls instead. This will stop being the case once rust-lang/rust#119820 lands, breaking your code.Please ask for clarification if you would like further information. I apologize for the inconvenience.