fix: Lychee output to file (fixes #214) #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Did you test it already on a fork? |
|
I have not tested it, unfortunately. I haven't found the time yet, sorry. |
|
This should then also address #216. |
|
I'm going to follow up with I'm not 100% sure how to test a forked GHA. |
|
@LilDrunkenSmurf You should be able to run the new version with output/print commands in an action targeting your branch with the changes. |
|
Thanks for the contribution. I merged the changes and they should be live in |
|
I plan to do a release of the action very soon. Then we should also have the fix with a proper release version. |
This was referenced Jan 5, 2024
Closed
renovate bot
added a commit
to mykso/myks
that referenced
this pull request
Jan 5, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [lycheeverse/lychee-action](https://github.com/lycheeverse/lychee-action) | action | minor | `v1.8.0` -> `v1.9.0` | --- ### Release Notes <details> <summary>lycheeverse/lychee-action (lycheeverse/lychee-action)</summary> ### [`v1.9.0`](https://github.com/lycheeverse/lychee-action/releases/tag/v1.9.0): Version 1.9.0 [Compare Source](https://github.com/lycheeverse/lychee-action/compare/v1.8.0...v1.9.0) #### What's Changed - Document the current directory for the cache argument example by [@​theredfish](https://github.com/theredfish) in [lycheeverse/lychee-action#193 - Add `*.rst` glob pattern to defaults by [@​kdeldycke](https://github.com/kdeldycke) in [lycheeverse/lychee-action#197 - Automatically pass Github token by [@​mre](https://github.com/mre) in [lycheeverse/lychee-action#196 - Always create output file; not only on error by [@​mre](https://github.com/mre) in [lycheeverse/lychee-action#199 - Bump actions/checkout from 3 to 4 by [@​dependabot](https://github.com/dependabot) in [lycheeverse/lychee-action#208 - add documentation on using the param when testing local files (as in… by [@​tgaff](https://github.com/tgaff) in [lycheeverse/lychee-action#211 - fix: Lychee output to file (fixes [#​214](https://github.com/lycheeverse/lychee-action/issues/214)) by [@​LilDrunkenSmurf](https://github.com/LilDrunkenSmurf) in [lycheeverse/lychee-action#215 - Add integration test for custom output paths ([#​215](https://github.com/lycheeverse/lychee-action/issues/215)) by [@​mre](https://github.com/mre) in [lycheeverse/lychee-action#217 - Add integration tests for absolute output path and `--dump` by [@​mre](https://github.com/mre) in [lycheeverse/lychee-action#218 #### New Contributors - [@​theredfish](https://github.com/theredfish) made their first contribution in [lycheeverse/lychee-action#193 - [@​kdeldycke](https://github.com/kdeldycke) made their first contribution in [lycheeverse/lychee-action#197 - [@​tgaff](https://github.com/tgaff) made their first contribution in [lycheeverse/lychee-action#211 - [@​LilDrunkenSmurf](https://github.com/LilDrunkenSmurf) made their first contribution in [lycheeverse/lychee-action#215 **Full Changelog**: lycheeverse/lychee-action@v1...v1.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/mykso/myks). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2In0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
added a commit
to Unleash/unleash
that referenced
this pull request
Jan 12, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [lycheeverse/lychee-action](https://github.com/lycheeverse/lychee-action) | action | minor | `v1.8.0` -> `v1.9.0` | `v1.9.1` | --- ### Release Notes <details> <summary>lycheeverse/lychee-action (lycheeverse/lychee-action)</summary> ### [`v1.9.0`](https://github.com/lycheeverse/lychee-action/releases/tag/v1.9.0): Version 1.9.0 [Compare Source](https://github.com/lycheeverse/lychee-action/compare/v1.8.0...v1.9.0) #### What's Changed - Document the current directory for the cache argument example by [@​theredfish](https://github.com/theredfish) in [lycheeverse/lychee-action#193 - Add `*.rst` glob pattern to defaults by [@​kdeldycke](https://github.com/kdeldycke) in [lycheeverse/lychee-action#197 - Automatically pass Github token by [@​mre](https://github.com/mre) in [lycheeverse/lychee-action#196 - Always create output file; not only on error by [@​mre](https://github.com/mre) in [lycheeverse/lychee-action#199 - Bump actions/checkout from 3 to 4 by [@​dependabot](https://github.com/dependabot) in [lycheeverse/lychee-action#208 - add documentation on using the param when testing local files (as in… by [@​tgaff](https://github.com/tgaff) in [lycheeverse/lychee-action#211 - fix: Lychee output to file (fixes [#​214](https://github.com/lycheeverse/lychee-action/issues/214)) by [@​LilDrunkenSmurf](https://github.com/LilDrunkenSmurf) in [lycheeverse/lychee-action#215 - Add integration test for custom output paths ([#​215](https://github.com/lycheeverse/lychee-action/issues/215)) by [@​mre](https://github.com/mre) in [lycheeverse/lychee-action#217 - Add integration tests for absolute output path and `--dump` by [@​mre](https://github.com/mre) in [lycheeverse/lychee-action#218 #### New Contributors - [@​theredfish](https://github.com/theredfish) made their first contribution in [lycheeverse/lychee-action#193 - [@​kdeldycke](https://github.com/kdeldycke) made their first contribution in [lycheeverse/lychee-action#197 - [@​tgaff](https://github.com/tgaff) made their first contribution in [lycheeverse/lychee-action#211 - [@​LilDrunkenSmurf](https://github.com/LilDrunkenSmurf) made their first contribution in [lycheeverse/lychee-action#215 **Full Changelog**: lycheeverse/lychee-action@v1...v1.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 7pm every weekday,before 5am every weekday" in timezone Europe/Madrid, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Unleash/unleash). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
chingor13
added a commit
to googleapis/repo-automation-bots
that referenced
this pull request
Aug 7, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [lycheeverse/lychee-action](https://github.com/lycheeverse/lychee-action) | action | minor | `v1.5.4` -> `v1.10.0` | --- ### Release Notes <details> <summary>lycheeverse/lychee-action (lycheeverse/lychee-action)</summary> ### [`v1.10.0`](https://github.com/lycheeverse/lychee-action/releases/tag/v1.10.0) [Compare Source](https://github.com/lycheeverse/lychee-action/compare/v1.9.3...v1.10.0) #### What's Changed - Update `actions/checkout` to version `4` by [@​jacobdalamb](https://github.com/jacobdalamb) in [lycheeverse/lychee-action#224 - Bump lychee to 0.15.0 by [@​mre](https://github.com/mre) in [lycheeverse/lychee-action#226 #### New Contributors - [@​jacobdalamb](https://github.com/jacobdalamb) made their first contribution in [lycheeverse/lychee-action#224 **Full Changelog**: lycheeverse/lychee-action@v1.9.3...v1.10.0 ### [`v1.9.3`](https://github.com/lycheeverse/lychee-action/releases/tag/v1.9.3): Version 1.9.3 [Compare Source](https://github.com/lycheeverse/lychee-action/compare/v1.9.2...v1.9.3) #### What's Changed - Bugfix: Pass custom `token` as input argument to action by [@​mre](https://github.com/mre) in [lycheeverse/lychee-action#222 Previously, the name of the token was incorrect, leading to no token being used if the user specified `with: [token: ...]`. Thanks to [@​tobon4](https://github.com/tobon4) for pointing this out. **Full Changelog**: lycheeverse/lychee-action@v1...v1.9.3 ### [`v1.9.2`](https://github.com/lycheeverse/lychee-action/releases/tag/v1.9.2): Version 1.9.2 [Compare Source](https://github.com/lycheeverse/lychee-action/compare/v1.9.1...v1.9.2) #### What's Changed - Bump actions/cache from 3 to 4 by [@​dependabot](https://github.com/dependabot) in [lycheeverse/lychee-action#221 - Bump peter-evans/create-issue-from-file from 4 to 5 by [@​dependabot](https://github.com/dependabot) in [lycheeverse/lychee-action#223 - Bump to lychee 0.14.2 in lycheeverse/lychee-action@eeb9cb6 **Full Changelog**: lycheeverse/lychee-action@v1...v1.9.2 ### [`v1.9.1`](https://github.com/lycheeverse/lychee-action/releases/tag/v1.9.1): Version 1.9.1 [Compare Source](https://github.com/lycheeverse/lychee-action/compare/v1.9.0...v1.9.1) This is a hotfix release which restores the behavior of the `accept` config parameter. Integers are accepted again as status codes. ```toml accept = [200, 201, 202, 203, 429] ``` is equivalent to ```toml accept = ["200..=203", 429] ``` Integers and strings (e.g. for ranges) can be mixed. ### [`v1.9.0`](https://github.com/lycheeverse/lychee-action/releases/tag/v1.9.0): Version 1.9.0 [Compare Source](https://github.com/lycheeverse/lychee-action/compare/v1.8.0...v1.9.0) #### What's Changed - Document the current directory for the cache argument example by [@​theredfish](https://github.com/theredfish) in [lycheeverse/lychee-action#193 - Add `*.rst` glob pattern to defaults by [@​kdeldycke](https://github.com/kdeldycke) in [lycheeverse/lychee-action#197 - Automatically pass Github token by [@​mre](https://github.com/mre) in [lycheeverse/lychee-action#196 - Always create output file; not only on error by [@​mre](https://github.com/mre) in [lycheeverse/lychee-action#199 - Bump actions/checkout from 3 to 4 by [@​dependabot](https://github.com/dependabot) in [lycheeverse/lychee-action#208 - add documentation on using the param when testing local files (as in… by [@​tgaff](https://github.com/tgaff) in [lycheeverse/lychee-action#211 - fix: Lychee output to file (fixes [#​214](https://github.com/lycheeverse/lychee-action/issues/214)) by [@​LilDrunkenSmurf](https://github.com/LilDrunkenSmurf) in [lycheeverse/lychee-action#215 - Add integration test for custom output paths ([#​215](https://github.com/lycheeverse/lychee-action/issues/215)) by [@​mre](https://github.com/mre) in [lycheeverse/lychee-action#217 - Add integration tests for absolute output path and `--dump` by [@​mre](https://github.com/mre) in [lycheeverse/lychee-action#218 #### New Contributors - [@​theredfish](https://github.com/theredfish) made their first contribution in [lycheeverse/lychee-action#193 - [@​kdeldycke](https://github.com/kdeldycke) made their first contribution in [lycheeverse/lychee-action#197 - [@​tgaff](https://github.com/tgaff) made their first contribution in [lycheeverse/lychee-action#211 - [@​LilDrunkenSmurf](https://github.com/LilDrunkenSmurf) made their first contribution in [lycheeverse/lychee-action#215 **Full Changelog**: lycheeverse/lychee-action@v1...v1.9.0 ### [`v1.8.0`](https://github.com/lycheeverse/lychee-action/releases/tag/v1.8.0): Version 1.8.0 [Compare Source](https://github.com/lycheeverse/lychee-action/compare/v1.7.0...v1.8.0) #### What's Changed - Update lychee to 0.13.0. - Adds support for showing the check duration in the JSON output. - Faster link suggestions by using concurrent Wayback Machine lookups. **Full Changelog**: lycheeverse/lychee-action@v1...v1.8.0 ### [`v1.7.0`](https://github.com/lycheeverse/lychee-action/releases/tag/v1.7.0): Version 1.7.0 [Compare Source](https://github.com/lycheeverse/lychee-action/compare/v1.6.1...v1.7.0) #### What's Changed - Fix three typos in README by [@​phieri](https://github.com/phieri) in [lycheeverse/lychee-action#184 - CI: Automatic vX tag update workflow by [@​tooomm](https://github.com/tooomm) in [lycheeverse/lychee-action#185 - Format arguments in CI pipeline by [@​mre](https://github.com/mre) in [lycheeverse/lychee-action#186 - Test lychee cache by [@​mre](https://github.com/mre) in [lycheeverse/lychee-action#187 - Cleanup tar archive; make installation more robst by [@​mre](https://github.com/mre) in [lycheeverse/lychee-action#189 - Readme: Add info about split up cache steps by [@​tooomm](https://github.com/tooomm) in [lycheeverse/lychee-action#190 - bump lychee version by [@​mre](https://github.com/mre) in [lycheeverse/lychee-action#192 #### New Contributors - [@​phieri](https://github.com/phieri) made their first contribution in [lycheeverse/lychee-action#184 **Full Changelog**: lycheeverse/lychee-action@v1.6.1...v1.7.0 ### [`v1.6.1`](https://github.com/lycheeverse/lychee-action/releases/tag/v1.6.1): Version 1.6.1 [Compare Source](https://github.com/lycheeverse/lychee-action/compare/v1.6.0...v1.6.1) #### Summary Hotfix release, which restores old behavior for cached links with status code 2xx. This temporarily broke some downstream pipelines. #### What's Changed - Bump lychee to 0.11.1 by [@​mre](https://github.com/mre) in [lycheeverse/lychee-action#181 **Full Changelog**: lycheeverse/lychee-action@v1.6.0...v1.6.1 ### [`v1.6.0`](https://github.com/lycheeverse/lychee-action/releases/tag/v1.6.0): Version 1.6.0 [Compare Source](https://github.com/lycheeverse/lychee-action/compare/v1.5.4...v1.6.0) #### What's Changed - Use random tempfile for `LYCHEE_TMP` by [@​mre](https://github.com/mre) in [lycheeverse/lychee-action#173 - Bump actions/checkout from 3.1.0 to 3.2.0 by [@​dependabot](https://github.com/dependabot) in [lycheeverse/lychee-action#175 - Bump actions/checkout from 2 to 3 by [@​dependabot](https://github.com/dependabot) in [lycheeverse/lychee-action#177 - Bump to lychee version 0.11.0 by [@​mre](https://github.com/mre) in [lycheeverse/lychee-action#180 **Full Changelog**: lycheeverse/lychee-action@v1.5.4...v1.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/googleapis/repo-automation-bots). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: Jeff Ching <chingor@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it evaluates the first
if [ ! -f "${LYCHEE_TMP}" ]; then, however it skips the second one that's essentially the same check.This combines them into a single if/else statement so it should start being evaluated.
Fixes #214