Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns-prefetch links should be excluded #1499

Closed
wackget opened this issue Sep 11, 2024 · 0 comments · Fixed by #1520
Closed

dns-prefetch links should be excluded #1499

wackget opened this issue Sep 11, 2024 · 0 comments · Fixed by #1520
Labels
enhancement New feature or request false-positive

Comments

@wackget
Copy link
Contributor

wackget commented Sep 11, 2024

Links of type dns-prefetch should not be checked by lychee. This is because they are only used to perform DNS lookups and never to fetch any content, e.g.:

<link rel='dns-prefetch' href='https://fonts.googleapis.com/' />

I am aware of an existing issue #897 which covers preconnect-type links but dns-prefetch is a separate type not covered by the proposed fix.
@wackget wackget mentioned this issue Sep 11, 2024
Merged
@mre mre added enhancement New feature or request false-positive labels Sep 21, 2024
wackget added a commit to wackget/lychee that referenced this issue Oct 8, 2024
@wackget
Exclude rel=dns-prefetch links
b8518f3 
Resolves lycheeverse#1499
@wackget wackget mentioned this issue Oct 8, 2024
Merged
@mre mre closed this as completed in #1520 Oct 11, 2024
@mre mre closed this as completed in e398325 Oct 11, 2024
mre added a commit that referenced this issue Oct 11, 2024
@mre @wackget
feat: Add tests for dns-prefetch (#1522)
913cf71 
* Exclude `rel=dns-prefetch` links

Resolves #1499

* Add tests for dns-prefetch

---------

Co-authored-by: wackget <136205263+wackget@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request false-positive
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude rel=dns-prefetch links wackget/lychee
2 participants
@mre @wackget