Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures in the 0.16.0 release #1513

Closed
orhun opened this issue Oct 6, 2024 · 3 comments
Closed

Test failures in the 0.16.0 release #1513

orhun opened this issue Oct 6, 2024 · 3 comments

Comments

@orhun
Copy link
Contributor

orhun commented Oct 6, 2024

I'm hitting these 2 failures while building lychee for Arch Linux:

Details
------------
 Nextest run ID 12f79d07-8cbf-4d29-9a91-879b073c65f2 with nextest profile: default
    Starting 319 tests across 14 binaries (7 tests skipped)
        PASS [   0.679s] benches::bench/extract extract from large docs
        FAIL [   0.020s] lychee::cli cli::test_basic_auth

--- STDOUT:              lychee::cli cli::test_basic_auth ---

running 1 test
test cli::test_basic_auth ... FAILED

failures:

failures:
    cli::test_basic_auth

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 74 filtered out; finished in 0.02s


--- STDERR:              lychee::cli cli::test_basic_auth ---
thread 'cli::test_basic_auth' panicked at /usr/src/debug/rust/rustc-1.81.0-src/library/core/src/ops/function.rs:250:5:
Unexpected failure.
code=101
stderr=``````
thread \'main\' panicked at /build/.cargo/registry/src/index.crates.io-6f17d22bba15001f/console-subscriber-0.4.0/src/lib.rs:262:9:
task tracing requires Tokio to be built with RUSTFLAGS=\"--cfg tokio_unstable\"!
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
command=`"/build/lychee/src/lychee-0.16.0/target/debug/lychee" "--verbose" "--basic-auth" "http://127.0.0.1:37767 username:password123" "-"`
stdin=`"http://127.0.0.1:37767"`
code=101
stdout=""
stderr=```
thread \'main\' panicked at /build/.cargo/registry/src/index.crates.io-6f17d22bba15001f/console-subscriber-0.4.0/src/lib.rs:262:9:
task tracing requires Tokio to be built with RUSTFLAGS=\"--cfg tokio_unstable\"!
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

   Canceling due to test failure
        FAIL [   0.020s] lychee::cli cli::test_cache_config

--- STDOUT:              lychee::cli cli::test_cache_config ---

running 1 test
test cli::test_cache_config ... FAILED

failures:

failures:
    cli::test_cache_config

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 74 filtered out; finished in 0.02s


--- STDERR:              lychee::cli cli::test_cache_config ---
thread 'cli::test_cache_config' panicked at /usr/src/debug/rust/rustc-1.81.0-src/library/core/src/ops/function.rs:250:5:
Unexpected failure.
code=101
stderr=``````
thread \'main\' panicked at /build/.cargo/registry/src/index.crates.io-6f17d22bba15001f/console-subscriber-0.4.0/src/lib.rs:262:9:
task tracing requires Tokio to be built with RUSTFLAGS=\"--cfg tokio_unstable\"!
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
command=`env -i "/build/lychee/src/lychee-0.16.0/target/debug/lychee" "--config" "/build/lychee/src/lychee-0.16.0/fixtures/configs/cache.toml" "-"`
stdin=`"http://127.0.0.1:43637"`
code=101
stdout=""
stderr=```
thread \'main\' panicked at /build/.cargo/registry/src/index.crates.io-6f17d22bba15001f/console-subscriber-0.4.0/src/lib.rs:262:9:
task tracing requires Tokio to be built with RUSTFLAGS=\"--cfg tokio_unstable\"!
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

------------
     Summary [   0.718s] 3/319 tests run: 1 passed, 2 failed, 0 skipped
        FAIL [   0.020s] lychee::cli cli::test_basic_auth
        FAIL [   0.020s] lychee::cli cli::test_cache_config
warning: 316/319 tests were not run due to test failure (run with --no-fail-fast to run all tests)
error: test run failed

Any idea about what's going on? 👀

@mre
Copy link
Member

mre commented Oct 7, 2024

Thanks @orhun.
It's the console subscriber. Since I don't think anyone uses that, I'll remove it with the next release.
Propably not worth it, but if you like, you can try to disable the subscriber:

tokio-console = ["dep:console-subscriber", "dep:tracing-subscriber"]

@orhun
Copy link
Contributor Author

orhun commented Oct 7, 2024

Thanks for letting me know - I don't know how I missed that from the logs, skill issue I guess.

The package is now updated :)

@orhun orhun closed this as completed Oct 7, 2024
@mre
Copy link
Member

mre commented Oct 7, 2024

skill issue I guess

Probably. 😜

Just kidding. Thanks for maintaining the package Orhun!

mre added a commit that referenced this issue Oct 12, 2024
The console subscriber is the source of quite a few papercuts like
#1513.

Since we don't use it at the moment, I decided to remove it.
mre added a commit that referenced this issue Oct 12, 2024
The console subscriber is the source of quite a few papercuts like
#1513.

Since we don't use it at the moment, I decided to remove it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants