Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude URLs ending with xmlrpc.php #1262

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Exclude URLs ending with xmlrpc.php #1262

merged 2 commits into from
Oct 6, 2023

Conversation

aj-stein-nist
Copy link
Contributor

Closes #1210.

@mre
Copy link
Member

mre commented Oct 6, 2023

Looks good. I'd merge it. Why is it a draft? 😅

@aj-stein-nist
Copy link
Contributor Author

aj-stein-nist commented Oct 6, 2023 •
edited
Loading

Looks good. I'd merge it. Why is it a draft? 😅

It was late and I hadn't tested it manually, is there a good way to test this and to unit tests or something?

@mre
Copy link
Member

mre commented Oct 6, 2023

The exclusion logic is already covered by a unit test. Maybe you want to add one for this pattern specifically, but it's also fine if not. 🙃

@aj-stein-nist aj-stein-nist marked this pull request as ready for review October 6, 2023 17:14
@aj-stein-nist
Copy link
Contributor Author

I marked it as ready then, sounds good. I forgot about October and Octoberfest. 😆

@mre mre merged commit 2109470 into lycheeverse:master Oct 6, 2023
7 checks passed
@mre
Copy link
Member

mre commented Oct 6, 2023

Thanks for your contribution. 🌟

@BrewTestBot BrewTestBot mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ignore checks to known XML-RPC endpoints
2 participants
@aj-stein-nist @mre