Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix missing permissions for uploading release assets #1330

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

askalski85
Copy link
Contributor

@askalski85 askalski85 commented Jan 4, 2024

Dear @mre ,
I've noticed the release workflow was not updated since long time and I think we are missing proper token permissions for uploading release assets. Please take a look and I hope you will like it.

Cheers,
Arek

@guimochila
Copy link

@mre could you have a look at this?

@askalski85
Copy link
Contributor Author

build failure unrelated to changes

     Checking lychee-lib v0.13.0 (/home/runner/work/lychee/lychee/lychee-lib)
error: matching over `()` is more explicit
   --> lychee-lib/src/types/input.rs:206:55
    |
206 |                         .process_read_dir(move |_, _, _, children| {
    |                                                       ^ help: use `()` instead of `_`: `()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
    = note: `-D clippy::ignored-unit-patterns` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::ignored_unit_patterns)]`

error: could not compile `lychee-lib` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...
error: could not compile `lychee-lib` (lib test) due to previous error
Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

@askalski85
Copy link
Contributor Author

The clippy suggested solution does not work, I am not rust expert to catch that ;-)

error[E0308]: mismatched types
   --> lychee-lib/src/types/input.rs:206:49
    |
206 |                         .process_read_dir(move |(), (), (), children| {
    |                                                 ^^
    |                                                 |
    |                                                 expected `Option<usize>`, found `()`
    |                                                 expected due to this
    |
    = note:   expected enum `std::option::Option<usize>`
            found unit type `()`

error[E0308]: mismatched types
   --> lychee-lib/src/types/input.rs:206:53
    |
206 |                         .process_read_dir(move |(), (), (), children| {
    |                                                     ^^
    |                                                     |
    |                                                     expected `Path`, found `()`
    |                                                     expected due to this

I will revert the fix commit and add suppression for the clippy error.

@askalski85
Copy link
Contributor Author

Suppression works, might be not a perfect solution but I can't really tell how to work around it better.

@mre mre merged commit 9a89afe into lycheeverse:master Jan 5, 2024
6 checks passed
@mre
Copy link
Member

mre commented Jan 5, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants