Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pkg-url for cargo binstall #1532

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

mondeja
Copy link
Contributor

@mondeja mondeja commented Oct 17, 2024

Previous to this patch, cargo binstall is using third-party source QuickInstall to install binaries.

$ cargo binstall lychee --manifest-path lychee-bin/Cargo.toml --dry-run
 INFO resolve: Resolving package: 'lychee'
 INFO resolve: Verified signature for package 'lychee-0.16.1-x86_64-unknown-linux-gnu': timestamp:1728250139	file:lychee-0.16.1-x86_64-unknown-linux-gnu.tar.gz	hashed
 WARN The package lychee v0.16.1 (x86_64-unknown-linux-gnu) has been downloaded from third-party source QuickInstall

After this, is using github.com releases:

$ cargo binstall lychee --manifest-path lychee-bin/Cargo.toml --dry-run
 INFO resolve: Resolving package: 'lychee'
 WARN The package lychee v0.16.1 (x86_64-unknown-linux-gnu) has been downloaded from github.com

I would like to add a regression test for this, but not sure where to put it. Are you testing package managers releases?

@mondeja mondeja changed the title Update pkg-url of cargo binstall Update pkg-url for cargo binstall Oct 17, 2024
@mre mre merged commit 93846b5 into lycheeverse:master Oct 17, 2024
7 checks passed
@mre
Copy link
Member

mre commented Oct 17, 2024

Thanks. Makes a lot of sense!

@mre mre mentioned this pull request Oct 14, 2024
@mondeja mondeja deleted the update-cargo-binstall branch October 17, 2024 16:48
This was referenced Oct 21, 2024
mre pushed a commit that referenced this pull request Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants