Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit when stdin ends #42

Merged
merged 3 commits into from
Oct 21, 2022
Merged

Exit when stdin ends #42

merged 3 commits into from
Oct 21, 2022

Conversation

lydell
Copy link
Owner

@lydell lydell commented Oct 19, 2022 •
edited
Loading

Closes #40.

@lydell lydell mentioned this pull request Oct 19, 2022
Closed
@lydell lydell marked this pull request as ready for review October 21, 2022 07:25
chazsconi
chazsconi reviewed Oct 21, 2022
View reviewed changes
Copy link
Contributor

@chazsconi chazsconi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I can confirm that when running as a Phoenix watcher the process now exits when Phoenix exits.

@lydell lydell merged commit fff4d53 into main Oct 21, 2022
@lydell lydell deleted the stdin-close branch October 21, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chazsconi chazsconi chazsconi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

elm-watch doesn't exit when stdin closes
2 participants
@lydell @chazsconi