-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cross-spawn as a dependency #66
base: main
Are you sure you want to change the base?
Conversation
@@ -15,6 +15,7 @@ | |||
"@types/ws": "8.5.4", | |||
"@typescript-eslint/eslint-plugin": "5.48.2", | |||
"@typescript-eslint/parser": "5.48.2", | |||
"cross-spawn": "7.0.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You moved this to dependencies, not devDependencies 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was tired. I meant that you moved it to devDependencies, rather than removing it, and this didn't modify any tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the point of the PR was to remove it from the actual package. The tests could be dealt with later (if at all, depending on what shenanigans I pulled there).
No description provided.