Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put node:* modules in a separate group by default #111

Merged
merged 4 commits into from
Sep 3, 2022
Merged

Conversation

lydell
Copy link
Owner

@lydell lydell commented Sep 3, 2022

Closes #109. Related to #20.

This puts node: imports in a separate group by default, above the npm packages group.

I think this makes sense, because the node: prefix clearly stands out among npm packages, and it’s a very simple regex (^node:), as opposed to supporting all Node.js builtins by name (#20 (comment)) – I think it’s good to keep the default groups simple.

@lydell lydell merged commit 0e3719e into main Sep 3, 2022
@lydell lydell deleted the node-group branch September 3, 2022 09:21
@lydell
Copy link
Owner Author

lydell commented Sep 3, 2022

Released in v8.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make a new group for the Node built-in packages import starting with "node:"
1 participant