Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #34, this PR ports the project to ESM. Tests work locally; we'll see if I fixed CI correctly.
I tested in the browser with the following code (to get a global variable):
I personally find #34 slightly more useful because it allows me to run everything in
file:
URLs; when testing, ESMimport
only works if I run a local server. But this code is definitely cleaner.Some notes:
.eslintrc.cjs
--experimental-vm-modules
so that it can manipulate ESMs.