Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to ESM #35

Closed
wants to merge 1 commit into from
Closed

Port to ESM #35

wants to merge 1 commit into from

Conversation

edemaine
Copy link

@edemaine edemaine commented Aug 2, 2021

As discussed in #34, this PR ports the project to ESM. Tests work locally; we'll see if I fixed CI correctly.

I tested in the browser with the following code (to get a global variable):

<script type="module">
  import stringify from "./index.js";
  window.stringify = stringify;
</script>

I personally find #34 slightly more useful because it allows me to run everything in file: URLs; when testing, ESM import only works if I run a local server. But this code is definitely cleaner.

Some notes:

@lydell
Copy link
Owner

lydell commented Sep 26, 2021

Hi! Just wanted to let you know I haven’t forgotten about this. I want to come back to this later this year.

@lydell
Copy link
Owner

lydell commented Jan 11, 2022

New year, still not done. It’s still on my list though.

@lydell
Copy link
Owner

lydell commented May 14, 2022

I finally made the decision to release as ESM only! I didn’t merge your PR in the end, since I decided to get rid of Jest. But thanks anyway for the PR! Version 4.0.0 is now available on npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants