Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix view visibility check failing on cells in scrolled table view #28

Merged
merged 1 commit into from
Aug 1, 2021
Merged

Fix view visibility check failing on cells in scrolled table view #28

merged 1 commit into from
Aug 1, 2021

Conversation

Tunous
Copy link
Contributor

@Tunous Tunous commented Jul 30, 2021

This pull request fixes issue where visibility checks failed for table view cells located outside of the original table view bounds. I've added a new test that reproduces this situation and made it pass.

gabriellanata
gabriellanata approved these changes Aug 1, 2021
View reviewed changes
Copy link
Contributor

@gabriellanata gabriellanata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I actually had it like this at first. I changed it because I thought "the frame is equal to the bounds translated to the superview", but I forgot about scroll views.

@gabriellanata gabriellanata merged commit 6c9bf50 into lyft:main Aug 1, 2021
@Tunous Tunous deleted the tableview-cell-visibility branch August 1, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriellanata gabriellanata gabriellanata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tunous @gabriellanata