Fix point calculation for twoWayOffset due to wrong angle direction #53
+10
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address incorrect calculation for a
twoWayOffset
function. Expected behaviour (I guess) was to have two touches with 180° with configurable angle to the horizont.After PR
fix.angle.mov
Before
Here is how it looks like for angle = 0:
horizontal.mov
And this is what we have for a 35 degrees angle:
angle.mov