Improve lifecycle #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosgriselli
approved these changes
Sep 22, 2024
| self.containerView.translatesAutoresizingMaskIntoConstraints = false | ||
| self.view.addSubview(self.containerView) | ||
|
|
||
| // We only activate the top and leading constraints to allow the content to size itself. |
There was a problem hiding this comment.
But we also activate bottom and trailing.
| } | ||
|
|
||
| private final class HammerViewController: UIViewController { | ||
| private let containerView = UIView() |
There was a problem hiding this comment.
It seems to me, we can just use self.view and do not create additional layer.
There was a problem hiding this comment.
True, but i prefer to keep this for now for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simulates view controller lifecycle more accurately