Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always update checkrun status for terraform workflows #719

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

asubrocky
Copy link
Contributor

Why?

  • Terraform workflows cannot cancel due to WaitForCancellation, so we might as well try to update the status of the checkrun.
  • We also think this will help with the non determinism issues we are seeing where cancellations can occur at different than expected times on replay, causing the checkrun cache to be inaccurate, thus causing wrong calls to either create or update.

@asubrocky asubrocky force-pushed the always-notify-checkrun-status branch 3 times, most recently from 7e6fa75 to a39f21c Compare October 10, 2023 17:50
Why?
* Terraform workflows cannot cancel due to WaitForCancellation, so we might as well try to update the status of the checkrun.
* We also think this will help with the non determinism issues we are seeing where cancellations can occur at different than expected times on replay, causing the checkrun cache to be inaccurate, thus causing wrong calls to either create or update.
@asubrocky asubrocky force-pushed the always-notify-checkrun-status branch from a39f21c to 2bb529b Compare October 10, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant