Improve drift detection perf, tests, and add some typehints #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achantavy
commented
Jun 14, 2023
| session: neo4j.Session, | ||
| query_directory: str, | ||
| state_serializer: StateSchema, | ||
| storage, |
There was a problem hiding this comment.
Not adding a typehint here because it seems like we're doing this ducktyping thing where we expect the storage object to have a write() function and other methods but I don't want to necessarily restrict it to just the existing storage.FileSystem object.
achantavy
commented
Jun 14, 2023
| @@ -92,10 +96,12 @@ def compare_states(start_state, end_state): | |||
| :return: list of tuples of differences between states in the form (dictionary, State object) | |||
| """ | |||
| differences = [] | |||
| # Use set for faster membership check | |||
| start_state_results = {tuple(res) for res in start_state.results} | |||
There was a problem hiding this comment.
Main change of this PR. Spend more memory for faster lookup.
achantavy
commented
Jun 14, 2023
| continue | ||
| drift = [] | ||
| drift: List[Union[str, List[str]]] = [] |
There was a problem hiding this comment.
I'm not a fan of how the list can have more than one type (and mypy isn't particularly happy about this either) but I don't want to break anything
ramonpetgrave64
approved these changes
Jun 14, 2023
chandanchowdhury
pushed a commit
to juju4/cartography
that referenced
this pull request
Jun 26, 2024
Uses a set membership check instead of iterating through each item in the list of results to detect drift. Adds unit test to ensure order of results does not matter in the drift detection check. Also adds some typehints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a set membership check instead of iterating through each item in the list of results to detect drift.
Adds unit test to ensure order of results does not matter in the drift detection check.
Also adds some typehints.