Further Sanitize User Input #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, cc: @diegonavarro-lyft @0xp4blo |
anshumanbh
approved these changes
Apr 22, 2024
meng-han
reviewed
Apr 22, 2024
Comment on lines
+826
to
+833
| if data.get('name') != _cred.name: | ||
| data['name'] = escape(data.get('name')) | ||
| for cred in Credential.data_type_date_index.query( | ||
| 'credential', | ||
| filter_condition=Credential.name == data['name']): | ||
| # Conflict, the name already exists | ||
| msg = f'Name already exists. See id: {cred.id}' | ||
| return jsonify({'error': msg, 'reference': cred.id}), 409 |
There was a problem hiding this comment.
what about the latency here? i remember you mentioned a high latency for check dup
There was a problem hiding this comment.
the whole dup check adds more latency since we need to decrypt credential pairs to verify if the cred is a full duplicate. this check is only for dup name, which is not as expensive
meng-han
approved these changes
Apr 22, 2024
Yueren-Wang
approved these changes
Apr 22, 2024
alejandroroiz
added a commit
that referenced
this pull request
Jul 24, 2024
This reverts commit 0bdd433.
alejandroroiz
added a commit
that referenced
this pull request
Jul 31, 2024
This reverts commit 8e24934.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we fix the following issues: