fix sqllab logging (apache#5862)

lyft · Oct 12, 2018 · c715a43 · c715a43
1 parent 3f3b543
commit c715a43
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/superset/sql_lab.py b/superset/sql_lab.py
@@ -100,7 +100,7 @@ def execute_sql(
     user_name=None, session=None, start_time=None,
 ):
     """Executes the sql query returns the results."""
-    if store_results:
+    if store_results and start_time:
         # only asynchronous queries
         stats_logger.timing(
             'sqllab.query.time_pending', utils.now_as_float() - start_time)

diff --git a/superset/views/core.py b/superset/views/core.py
@@ -2338,7 +2338,7 @@ def results(self, key):
         blob = results_backend.get(key)
         stats_logger.timing(
             'sqllab.query.results_backend_read',
-            read_from_results_backend_start - utils.now_as_float(),
+            utils.now_as_float() - read_from_results_backend_start,
         )
         if not blob:
             return json_error_response(