update package-lock.json, since our deps may be different #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## lyft-master #23 +/- ##
===============================================
- Coverage 72.39% 64.02% -8.38%
===============================================
Files 81 438 +357
Lines 11097 21588 +10491
Branches 0 2394 +2394
===============================================
+ Hits 8034 13822 +5788
- Misses 3063 7628 +4565
- Partials 0 138 +138
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of cherry-picks in our history, and they may cause us to have deps that won't be in the upstream-provided package-lock.json. I'm not completely sure if this is the source of the issue we have here, but running
npm ion this branch produced the diff that I am submitting now.Generally speaking we probably need to generate the package-lock.json for every merge into
lyft-masterjust to be safe. (Assuming this ends up being the lone cause of test failures we were seeing...) Since CI installs the deps from the lock file it needs to be pregenerated for CI to pass.