Bring back okta auth #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7aeb3e2.
yeameen
commented
Feb 4, 2020
| <dependency> | ||
| <groupId>org.eclipse.jetty</groupId> | ||
| <artifactId>jetty-server</artifactId> | ||
| <version>9.4.14.v20181114</version> |
There was a problem hiding this comment.
Using an older version to resolve conflicts
|
lgtm as long as @JamesRTaylor is good with it too |
|
👍 Would be important to think about how to encapsulate the Lyft-specific part of this PR and contribute back the rest to OSS presto. Otherwise, it makes it more difficult to move to newer versions of presto. |
Right now it has several Lyft specific configs & code. I am going to merge it (to unblock prestoproxy) and created a task to make this more generic - https://jira.lyft.net/browse/DATA-9478 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to older version of jetty to resolve dependency conflicts.
Verification
mvn clean package -DskipTestssuccessful