-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
job:undefined when prefix contain colon symbol #96
Comments
@vothanhkiet I will appreciate PR. |
lykmapipo
added a commit
that referenced
this issue
Jun 13, 2017
why did we lock dependencies? among other things, this locked us into a dangerously-broken version of Redlock (v2.1.1) |
indeed, it probably would! FWIW, I've had good luck with Redlock 3.0.0. |
@schmod I've tried Redlock 3.0.0 with no luck, not sure why :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When validate expired key, we've already include the prefix, however, when extract the job unique ID, we assume that the expired key has only 3 or 4 parts, therefore, if the prefix contain additional colon symbol, _getJobUUID return undefined value
Solution: can we use the last part as UUID ?
The text was updated successfully, but these errors were encountered: