Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: modify guardian_lose_with_guards win condition in guardian #463

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bugmen0t
Copy link
Contributor

@bugmen0t bugmen0t commented Dec 21, 2020

Recent guardian game [~2010-12-20 23:00 UTC] had this rather surprising interaction:
The day started with 3 wolves alive, 2 GA, and 1 vil alive.
wolf gunner shoots and wounds one of GA, and gets lynched afterward.
On their lynch, guardian_lose_with_guards gets triggered.
Triggering wolf win condition on wolf lynch seems counterintuitive, so this patch seeks to alleviate that [lpl does not include absent players during the day, so that's why I chose this approach].

An alternate fix would be switching lwolves == lguardians to lwolves >= lguardians so wolves would get their win when GA was shot, not sure what was an intention here.

@bugmen0t
Copy link
Contributor Author

@skizzerz
Copy link
Member

skizzerz commented Dec 25, 2020

The point of the absent status is that those people are counted as not in the village for all win condition checking. It should probably be >= instead of == though so it ended earlier. Also lguardians should exclude absent GAs which it currently isn't doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants