New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed spine publishing and publishing and subscribing in the same process #1002

Merged

lodoyun merged 1 commit into lynckia:master from lodoyun:fix/SpinePublish

Aug 10, 2017

Contributor

lodoyun commented Aug 10, 2017

Description
This PR fixes two problems:

Spine was not properly creating Streams for publication - this PR updates it to use the new API
hasAudio() and hasVideo() were returning the full video or audio entries of the configuration. When creating the Connection getErizoConnectionOpts was passing in the subscribing side, where we only need true or false

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.


          Fixed publishing in Spine

9fe16f7

lodoyun merged commit eb3ee59 into lynckia:master

lodoyun deleted the fix/SpinePublish branch

January 10, 2018 10:16

Arri98 pushed a commit to Arri98/licode that referenced this pull request


          Fixed publishing in Spine (lynckia#1002)

fdfc3e1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet