Added first stress tests and improve test scripts #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcague
changed the title
lodoyun
approved these changes
Sep 8, 2017
test/perf-tests.js
Outdated
| return getLicodeInstance().stopLicode(); | ||
| describe('Default Licode Configuration', function() { | ||
| beforeEach(function() { | ||
| test = Object.assign({}, BASIC_TEST); |
There was a problem hiding this comment.
For readability, and maybe for future things, I'd consider passing the test configuration (BASIC_TEST) as a parameter in runTestWith
| @@ -11,6 +11,7 @@ log4j.appender.A1.layout.ConversionPattern=%d - %p [%t] %c - %m%n | |||
|
|
|||
| log4j.logger.DtlsTransport=WARN | |||
| log4j.logger.LibNiceConnection=WARN | |||
| log4j.logger.NicerConnection=WARN | |||
test/perf-tests.js
Outdated
| numberOfInstances: 2, | ||
| imageId: 'ami-2ff3e756', | ||
| numberOfInstances: 1 + TOTAL_SPINE_SERVERS, | ||
| imageId: 'ami-ebfce892', |
There was a problem hiding this comment.
Consider making the AWS ami ID a env variable just like the others
|
|
||
| const LICODE_RUN_COMMAND = | ||
| 'sudo docker run --name licode --log-driver none \ | ||
| --network="host" \ |
| return this._execCommand('sudo yum update -y') | ||
| .then(() => this._execCommand('sudo sh -c \'echo "root hard nofile 65536" >> /etc/security/limits.conf\'')) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the first stress tests. And I continued refactoring the scripts somehow to improve test readability.
Changes in Client or Server public APIs
Not needed.
[] It includes documentation for these changes in
/doc.