Erizo Controller refactoring to add Clients and Channels #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice to catch the socket disconnection event and pass it to clients just to be able to close p2p connections. |
|
@kekkokk thanks for the heads up! will add a fix to this PR |
|
@kekkokk done, can you check it please? |
aalonsog
approved these changes
Sep 28, 2017
| rpcPublic[body.message.method].apply(rpcPublic, body.message.args); | ||
| try { | ||
| rpcPublic[body.message.method].apply(rpcPublic, body.message.args); | ||
| } catch(e) { |
| if (socket.room.streams[streamId]) { | ||
| delete socket.room.streams[streamId]; | ||
| } | ||
| callback(true); |
There was a problem hiding this comment.
I will miss these lines here... ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some code refactoring in Erizo Controller. Now we use the next models to improve code readability:
Changes in Client or Server public APIs
Not needed. All changes are in the backend.
[] It includes documentation for these changes in
/doc.