Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to force the client to use only TURN candidates #1043

Merged
merged 2 commits into from
Sep 28, 2017

Conversation

jcague
Copy link
Contributor

@jcague jcague commented Sep 28, 2017

Description

Add an option to force the client to use only TURN candidates

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

We can now force the client to use a TURN server when publishing/subscribing by setting the next parameter:

room.publish(localStream, {forceTurn: true});
  • It includes documentation for these changes in /doc.

@kekkokk
Copy link
Contributor

kekkokk commented Sep 28, 2017

I suggest to automatically activate this feature after 2 subsequent publish/subscribe fail as it would be probably the only option left to make the call works.

@jcague
Copy link
Contributor Author

jcague commented Sep 28, 2017

I don't think it's necessary, but we can consider it in the future if we detect multiple cases.

@jcague jcague merged commit 6547cc6 into lynckia:master Sep 28, 2017
@jcague jcague deleted the add/option_to_force_turn branch September 28, 2017 15:22
@kekkokk
Copy link
Contributor

kekkokk commented Sep 28, 2017

I experienced an issue with 2 different customers where their firewall blocked the stun binding request if were made too closely (a sort of ddos protection I think).
I was stuck in a loop where a stream-failed event were fired and tried to re-subscribe. The only option for me was to force that mechanism :(

@kekkokk
Copy link
Contributor

kekkokk commented Sep 28, 2017

Also, another interesting feature would be dynamically generate ice Servers without breaking the async structure of the process.
I mean, 99% of us is using a third party library to get turn credentials such as xirsys or twilio.
so everytime an user try to publish/subscribe a stream it would be nice to have a place where to put inside an async call to the preferred service which returns an ice config and make the process of publish/subscribe start

Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants