Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H264 annex b parser #1092

Merged
merged 2 commits into from
Dec 13, 2017
Merged

H264 annex b parser #1092

merged 2 commits into from
Dec 13, 2017

Conversation

Trisfald
Copy link
Contributor

Rewriting of H264 parser in order to support the Annex B specification. It works with H264 streams in both Single NAL unit mode and Non-interleaved mode. This implementation is more or less equivalent to the one used by ffmpeg.
We have successfully used this PR to record H264 streams. The recording part is not included here because our version of ExternalOutput is quite different from master; I can submit a generic depacketizer for vp8/h264 if that would be useful.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! it's always good to have a complete parser! thanks!. And sure, please contribute with better depacketizers!

@jcague jcague merged commit 2bd9aad into lynckia:master Dec 13, 2017
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants