Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix mediaSource overwriting for Firefox screen constraint #1106

Merged
merged 4 commits into from
Jan 4, 2018
Merged

fix mediaSource overwriting for Firefox screen constraint #1106

merged 4 commits into from
Jan 4, 2018

Conversation

mkhahani
Copy link
Contributor

This PR enables to set the mediaSource to screen or window in Firefox screen constraints:

const screenConfig = {
  screen: true,
  video: {
    mediaSource: 'window',
  },
}

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

jcague
jcague approved these changes Jan 2, 2018
View reviewed changes
Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jcague jcague merged commit 32d4128 into lynckia:master Jan 4, 2018
@mkhahani mkhahani deleted the fix-ff-mediasource branch April 14, 2019 06:20
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
@mkhahani @jcague
fix mediaSource overwriting for Firefox screen constraint (lynckia#1106)
bca3421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcague jcague jcague approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkhahani @jcague