Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if targetClient is undefined #1110

Merged
merged 2 commits into from
Jan 4, 2018
Merged

check if targetClient is undefined #1110

merged 2 commits into from
Jan 4, 2018

Conversation

kekkokk
Copy link
Contributor

@kekkokk kekkokk commented Jan 3, 2018

Sometimes happens that targetClient is undefined and the whole thing crashes because can't find sendMessage of undefined;

[] It needs and includes Unit Tests
[] It includes documentation for these changes in /doc.

jcague
jcague approved these changes Jan 4, 2018
View reviewed changes
Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@jcague jcague merged commit a48cdd6 into lynckia:master Jan 4, 2018
@kekkokk kekkokk deleted the fix/ec_targetclient branch January 5, 2018 14:31
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
@kekkokk @jcague
check if targetClient is undefined (lynckia#1110)
03feb52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcague jcague jcague approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kekkokk @jcague