Initial support for multiple MediaStreams in a single WebRtcConnection #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodoyun
reviewed
Mar 5, 2018
erizo/src/erizo/WebRtcConnection.cpp
Outdated
| RtcpHeader *chead = reinterpret_cast<RtcpHeader*> (buf); | ||
| uint32_t ssrc = head->getSSRC(); | ||
| if (chead->isRtcp()) { | ||
| ssrc = chead->getSourceSSRC(); |
There was a problem hiding this comment.
I think this won't work for sender reports. In that case, we need chead->getSSRC()
erizo/src/erizo/WebRtcConnection.cpp
Outdated
| ssrc = chead->getSourceSSRC(); | ||
| } | ||
| forEachMediaStream([packet, transport, ssrc] (const std::shared_ptr<MediaStream> &media_stream) { | ||
| if (media_stream->isSourceSSRC(ssrc) || media_stream->isSinkSSRC(ssrc)) { |
There was a problem hiding this comment.
This is ok. isSourceSSRC would make sure packets from a publisher are properly routed while isSink would work for feedback packets from a subscriber.
| local_sdp_->audio_ssrc = media_stream_->getAudioSinkSSRC(); | ||
| forEachMediaStream([this] (const std::shared_ptr<MediaStream> &media_stream) { | ||
| local_sdp_->video_ssrc_list.push_back(media_stream->getVideoSinkSSRC()); | ||
| local_sdp_->audio_ssrc = media_stream->getAudioSinkSSRC(); |
There was a problem hiding this comment.
This is not part of this PR but, do you have a plan here? The obvious solution is to have another list for audio ssrcs.
There was a problem hiding this comment.
I'd rather move the ssrc tracking to a new class called stream_sdp or similar.
jcague
force-pushed
the
add/mux_streams_by_ssrcs
branch
from
8ef0650
to
e8cd914
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds initial support for handling multiple streams in a single WebRtcConnection inside Erizo.
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
Not needed.
[] It includes documentation for these changes in
/doc.