Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses new promise-based API to fix simulcast in Firefox #1202

Merged
merged 2 commits into from
Apr 26, 2018
Merged

Uses new promise-based API to fix simulcast in Firefox #1202

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af531e9
Uses new promise-based API to fix simulcast in Firefox
jcague Apr 26, 2018
e9d509c
Merge branch 'master' into fix/firefox_simulcast
jcague Apr 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions erizo_controller/erizoClient/src/webrtc-stacks/FirefoxStack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,29 +23,34 @@ const FirefoxStack = (specInput) => {
for (let layer = totalLayers - 1; layer >= totalLayers - numSpatialLayers; layer -= 1) {
parameters.encodings.push(possibleLayers[layer]);
}
sender.setParameters(parameters);
return sender.setParameters(parameters);
};

const enableSimulcast = () => {
if (!that.simulcast) {
return;
return [];
}
const promises = [];
that.peerConnection.getSenders().forEach((sender) => {
if (sender.track.kind === 'video') {
getSimulcastParameters(sender);
promises.push(getSimulcastParameters(sender));
}
});
return promises;
};

that.enableSimulcast = sdp => sdp;

const baseCreateOffer = that.createOffer;

that.createOffer = (isSubscribe, forceOfferToReceive = false, streamId = '') => {
let promises = [];
if (isSubscribe !== true) {
enableSimulcast();
promises = enableSimulcast();
}
baseCreateOffer(isSubscribe, forceOfferToReceive, streamId);
Promise.all(promises).then(() => {
baseCreateOffer(isSubscribe, forceOfferToReceive, streamId);
});
};

return that;
Expand Down