Fix build script and generation of Eclipse CDT #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcague
reviewed
May 11, 2018
erizo/generateEclipseProject.sh
Outdated
| @@ -6,7 +6,7 @@ BIN_DIR="build" | |||
| if [ -d $BIN_DIR ]; then | |||
| cd $BIN_DIR | |||
| # Set to Debug to be able to debug in Eclipse | |||
| cmake -G"Eclipse CDT4 - Unix Makefiles" -D ERIZO_BUILD_TYPE=debug ../src | |||
| cmake -G "Eclipse CDT4 - Unix Makefiles" -D ERIZO_BUILD_TYPE=debug ../build/debug | |||
There was a problem hiding this comment.
I think this line might be wrong... can you try with this version of generateEclipseProject.sh I made by adding the Eclipse label please?
#!/usr/bin/env bash
set -e
SCRIPT=`pwd`/$0
FILENAME=`basename $SCRIPT`
PATHNAME=`dirname $SCRIPT`
BASE_BIN_DIR="build"
generateVersion() {
echo "generating $1"
BIN_DIR="$BASE_BIN_DIR/$1"
if [ -d $BIN_DIR ]; then
cd $BIN_DIR
else
mkdir -p $BIN_DIR
cd $BIN_DIR
fi
cmake ../../src "-DERIZO_BUILD_TYPE=$1" -G"Eclipse CDT4 - Unix Makefiles"
cd $PATHNAME
}
generateVersion debug
jcague
reviewed
May 11, 2018
erizo/buildProject.sh
Outdated
| cd $d | ||
| make $* | ||
| cd .. | ||
| for entry in "$BIN_DIR"/* |
There was a problem hiding this comment.
Is there anything in the previous version that is not working? I would remove these changes otherwise
There was a problem hiding this comment.
no just a cleaner syntax i think
|
I think you can merge |
|
did the file work for you then? |
|
yeah! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix build problems
[] It needs and includes Unit Tests
[] It includes documentation for these changes in
/doc.