Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exceptions happening due to too high marker rates #1359

Merged
merged 3 commits into from
Feb 12, 2019

Conversation

jcague
Copy link
Contributor

@jcague jcague commented Feb 12, 2019

Description

There is an exception that happens from time to time in Erizo due to a bad calculation in one of the stats. The issue happens when few time passes since we start the stat and we ask for data.
I added a Unit Test to check it does not happen again in the future.

  • It needs and includes Unit Tests

Changes in Client or Server public APIs

Not needed.

[] It includes documentation for these changes in /doc.

Copy link
Contributor

@lodoyun lodoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Looks good to me 👍

@jcague jcague merged commit f3aabf5 into lynckia:master Feb 12, 2019
@jcague jcague deleted the fix/fix/too_high_marker_rates branch February 12, 2019 12:14
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants