Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add periodic Pli handler #1493

Merged
merged 6 commits into from
Oct 28, 2019
Merged

Conversation

lodoyun
Copy link
Contributor

@lodoyun lodoyun commented Oct 25, 2019

Description
This PR optimizes the way we request keyframes when in slideshow. Instead of using an Interval in ErizoJS, this implements a handler in C++ erizo that periodically checks if a new keyframe is needed and requests it.

  • It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor comments

erizo/src/erizo/rtp/PeriodicPliHandler.cpp Outdated Show resolved Hide resolved
erizo/src/erizo/rtp/PeriodicPliHandler.cpp Outdated Show resolved Hide resolved
@lodoyun lodoyun merged commit d878442 into lynckia:master Oct 28, 2019
@lodoyun lodoyun deleted the add/PeriodicPlisHandler branch October 28, 2019 12:11
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants