Fix RR handling for SenderBWE #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodoyun
reviewed
Nov 28, 2019
| chead->getSSRC(), | ||
| chead->getSourceSSRC(), | ||
| chead->getPacketType()); | ||
| // ELOG_DEBUG("%s ssrc %u, sourceSSRC %u, PacketType %u", connection_->toLog(), |
There was a problem hiding this comment.
good catch, that's an annoying log when we set the log level to DEBUG so I'll remove it
| avg_delay += rr_info->delay / rr_delay_data_size; | ||
| }); | ||
| if (period_packets_sent_ > 0) { | ||
| uint32_t fraction_lost = total_packets_lost * 255 / period_packets_sent_; |
There was a problem hiding this comment.
I think you can't calculate the fraction lost in a period from the packets lost you get in a Receiver Report. You would have to keep track of the differences in packet loss between two consecutive Receiver Reports since it indicates the cumulative lost packets.
lodoyun
approved these changes
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were still cases where the SenderBandwidthEstimationHandler was not calculating the bandwidth estimation properly. This PR fixes them. The problem was that we were updating the same estimator with RRs received from multiple streams.
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
Not needed.
[] It includes documentation for these changes in
/doc.